WORLDSERVICE-79: Enable Reverb on LIVE for PIDGIN #12375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvaliani
reviewed
Feb 7, 2025
| @@ -80,6 +80,14 @@ describe('sendBeacon', () => { | |||
| expect(reverbMock.viewEvent).toHaveBeenCalledTimes(1); | |||
| }); | |||
|
|
|||
| it('should not call Reverb viewEvent if Reverb is not enabled for a service', async () => { | |||
| const sendBeacon = require('./index').default; | |||
There was a problem hiding this comment.
Would it be better to declare the sendBeacon at a higher level within the describe block so that it can be re-used for each unit test or does it have to be declared each time?
There was a problem hiding this comment.
I've updated how the test is set up to enable us to mock onClient
in a manner that enables use to import sendBeacon once.
pvaliani
approved these changes
Feb 7, 2025
….com:bbc/simorgh into WORLDSERVICE-79-enable-reverb-on-live-pidgin
amoore108
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA WORLDSERVICE-79
Overall changes
Enable Reverb tracking for PIDGIN on LIVE.
Code changes
isLivecheck to lift the restriction barring Reverb tracking on LIVE.Testing
Networktab, verify that page view tracking and component event tracking is done via Reverb.Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines